Split McpTasksCapability into ServerMcpTasksCapability and ClientMcpTasksCapability#1529
Open
jayaraman-venkatesan wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
mikekistler
approved these changes
May 8, 2026
Contributor
mikekistler
left a comment
mikekistler
left a comment
There was a problem hiding this comment.
Looks good. 👍
Just a few minor documentation issues to fix.
Comment on lines
+11
to
+13
| /// The tasks capability enables servers to augment their requests with tasks for long-running | ||
| /// operations. Tasks are durable state machines that carry information about the underlying | ||
| /// execution state of requests. |
Contributor
There was a problem hiding this comment.
Tasks are not necessary for long-running operations.
Suggested change
| /// The tasks capability enables servers to augment their requests with tasks for long-running | |
| /// operations. Tasks are durable state machines that carry information about the underlying | |
| /// execution state of requests. | |
| /// The tasks capability enables servers to augment their requests with tasks to enable status | |
| /// monitoring and persistent result retreval. Tasks are durable state machines that carry | |
| /// information about the underlying execution state of requests. |
Comment on lines
75
to
77
| /// The tasks capability enables clients to augment their requests with tasks for long-running | ||
| /// operations. When present, clients can request that certain operations (like tool calls) | ||
| /// execute asynchronously, with the ability to poll for status and retrieve results later. |
Contributor
There was a problem hiding this comment.
Tasks are not necessary for long-running operations.
Suggested change
| /// execute asynchronously, with the ability to poll for status and retrieve results later. | |
| /// The tasks capability enables clients to augment their requests with tasks to enable status | |
| /// monitoring and persistent result retreval. When present, clients can request that certain | |
| /// operations (like tool calls) support the ability to poll for status and retrieve results later. |
Comment on lines
+11
to
+13
| /// The tasks capability enables clients to augment their requests with tasks for long-running | ||
| /// operations. Tasks are durable state machines that carry information about the underlying | ||
| /// execution state of requests. |
Contributor
There was a problem hiding this comment.
Tasks are not necessary for long-running operations.
Suggested change
| /// The tasks capability enables clients to augment their requests with tasks for long-running | |
| /// operations. Tasks are durable state machines that carry information about the underlying | |
| /// execution state of requests. | |
| /// The tasks capability enables clients to augment their requests with tasks to enable status | |
| /// monitoring and persistent result retreval. Tasks are durable state machines that carry | |
| /// information about the underlying execution state of requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split
McpTasksCapabilityintoServerMcpTasksCapabilityandClientMcpTasksCapabilityCloses #1183
What changed
McpTasksCapabilityandRequestMcpTasksCapabilitywere shared by bothServerCapabilities.TasksandClientCapabilities.Tasks, but their valid sub-capabilities are role-specific:tasks.requests.tools.calltasks.requests.sampling.createMessageandtasks.requests.elicitation.createThe single shared type allowed setting sampling/elicitation capabilities on a server (and tools on a client)
with no compile-time error.
After this change
ServerMcpTasksCapabilityServerCapabilities.TasksServerRequestMcpTasksCapability—ToolsonlyClientMcpTasksCapabilityClientCapabilities.TasksClientRequestMcpTasksCapability—Sampling+ElicitationonlyEach capability file is named after its dominant type, consistent with the existing convention in the
Protocol/folder.No behavioral changes — JSON property names and all capability check paths are identical.